Refactor GRHD project
Compare changes
Files
3+ 20
− 2
@@ -7,7 +7,7 @@
@@ -95,6 +95,10 @@ display(γ4ud)
@@ -147,6 +151,20 @@ display(γhat.det())
@@ -195,7 +213,7 @@ for (c, Γ) in zip(sphere_coords, sphere_Γs):
Major rework of GRHD project to include new broadcasting interface. The goal is to get a TOV evolution with the AV method.
PR contains various refactors:
initialdata/
: We promote this to a separate env in order to add CairoMakie
for plotting.initialdata/SphericalAccretion.jl
solver so that it agrees with various references: solver from bugner's thesis (extract from bamps
), plots from two papers from Papadoulos.initialdata/TOV.jl
to not depend on dg1d.jl
anymore, instead use OrindaryDiffEq
and CairoMakie
for plotscons2prim
from SRHD
. these two versions should be merged eventually, but will do in a separate PRspherical1d
formulation: this is a rewrite of the evolution GRHD equations to work with non-zero radial shift vector. this is needed to evolve the spherical accretion test in cowling approximation where there should be no dynamics.rescaled_spherical1d
formulation: this is a rewrite of the previous formulation based on the generalized Valencia formulation (cf. Montero, Baumgarte paper from 2017); the auxiliary metric is chosen such that coordinate singularities at r=0
in the source terms are cancelled; doesn't work atmspherical1d
to include r=0
in the domain by using symmetry conditions to evaluate source terms at r=0
(workaround for rescaled_spherical1d
not working right now)differentiate!
method on Mesh
in order to compute derivatives by hand, if needed