GRHD: Refactor c2p (!150)
- Mainly refactors `c2p` in order to allow to ignore the total energy density in the recovery procedure. This is possible for cold equations of state, where we don't need to evolve tau. - The `c2p` now also incorporates a conservative fixing that we adapted from from arXiv:1306.4953, Appendix. - We had to update reftest data for the SRHD simple wave and GRHD bondi tests. Especially the GRHD bondi tests improved from not using tau in the reconstruction. - We also updated the default value `atm_treshold_factor` so that it is now slightly large than one. This fixes some errors where we misidentified atmosphere states as being below atmosphere, before the c2p procedure started. - Because this PR was cherry-picked from the fa/doublecartoon+av branch, we also brought over the changes in the naming of variables of the doublecartoon formulation (which should have went into another PR, but I was too lazy to entangle those changes first). ---- I noticed that the number of allocs in `rhs` sections are now quite increased. This is particularly bad for the SRHD tests. My guess is this is due to this refactor now passing on both EoSs as parameters to the c2p routine.
parent
3cb4bbbc
No related branches found
No related tags found
Showing
- src/EquationOfState/EquationOfState.jl 5 additions, 5 deletionssrc/EquationOfState/EquationOfState.jl
- src/GRHD/GRHD.jl 4 additions, 4 deletionssrc/GRHD/GRHD.jl
- src/GRHD/cons2prim.jl 152 additions, 185 deletionssrc/GRHD/cons2prim.jl
- src/GRHD/doublecartoon.jl 15 additions, 23 deletionssrc/GRHD/doublecartoon.jl
- src/GRHD/rhs.jl 4 additions, 4 deletionssrc/GRHD/rhs.jl
- src/GRHD/setup.jl 1 addition, 1 deletionsrc/GRHD/setup.jl
- src/GRHD/spherical1d.jl 5 additions, 13 deletionssrc/GRHD/spherical1d.jl
- src/SRHD/cons2prim.jl 4 additions, 4 deletionssrc/SRHD/cons2prim.jl
- test/IntegrationTests/refs/fv_grhd_bondi_accretion/output1d.h5 0 additions, 0 deletions...IntegrationTests/refs/fv_grhd_bondi_accretion/output1d.h5
- test/IntegrationTests/refs/fv_superbee_grhd_bondi_accretion/output1d.h5 0 additions, 0 deletions...onTests/refs/fv_superbee_grhd_bondi_accretion/output1d.h5
- test/IntegrationTests/refs/grhd_bondi_accretion/output1d.h5 0 additions, 0 deletionstest/IntegrationTests/refs/grhd_bondi_accretion/output1d.h5
- test/IntegrationTests/refs/srhd_simple_wave_avmda/output1d.h5 0 additions, 0 deletions.../IntegrationTests/refs/srhd_simple_wave_avmda/output1d.h5
- test/IntegrationTests/refs/srhd_simple_wave_fv/output1d.h5 0 additions, 0 deletionstest/IntegrationTests/refs/srhd_simple_wave_fv/output1d.h5
- test/IntegrationTests/refs/srhd_simple_wave_fv_tvb/output1d.h5 0 additions, 0 deletions...IntegrationTests/refs/srhd_simple_wave_fv_tvb/output1d.h5
Loading
Please register or sign in to comment