GRHD: ban `ParameterDB` usage from `rhs` due to type instabilities...

GRHD: ban `ParameterDB` usage from `rhs` due to type instabilities (!188)

src/GRHD/callbacks.jl

@@ -52,8 +52,8 @@ end
 
 compute_atmosphere_mask(env, P, mesh) = nothing
 function compute_atmosphere_mask(env, P, mesh::Mesh1d{SpectralElement})
-  enforce        = P.prmsdb["GRHD"]["c2p_enforce_atm"]
-  enforce_causal = P.prmsdb["GRHD"]["c2p_enforce_causal_atm"]
+  enforce        = P.prms.c2p_enforce_atm
+  enforce_causal = P.prms.c2p_enforce_causal_atm
   (!enforce && !enforce_causal) && return
   if formulation(P) === :valencia1d
     broadcast_volume!(cons2prim_valencia1d, P.equation, env.mesh)

src/GRHD/setup.jl

@@ -34,11 +34,20 @@ function Project(env::Environment, prms)
   cold_K, cold_Γ = prms["GRHD"]["c2p_cold_eos_parameters"]
   cold_eos = Polytrope(cold_K, cold_Γ)
   c2p_set_atmosphere_on_failure = prms["GRHD"]["c2p_set_atmosphere_on_failure"]
+  c2p_enforce_atm = Bool(prms["GRHD"]["c2p_enforce_atm"])
+  c2p_enforce_causal_atm = Bool(prms["GRHD"]["c2p_enforce_causal_atm"])
+  atm_evolve = Bool(prms["GRHD"]["atm_evolve"])
+  hrsc = Symbol(prms["GRHD"]["hrsc"])
+  freeze_vars = Symbol.(prms["GRHD"]["freeze_vars"])
+  fv_numerical_flux = prms["GRHD"]["fv_numerical_flux"]
+  id = prms["GRHD"]["id"]
+  bc = prms["GRHD"]["bc"]
   fixedprms = (; av_regularization=:covariant, id_smooth=true,
                  bernstein, slope_limiter_method, slope_limiter_tvb_M,
-                 c2p_dynamic_atm,
-                 c2p_set_atmosphere_on_failure,
-                 av_drag, problem)
+                 c2p_dynamic_atm, atm_evolve,
+                 c2p_set_atmosphere_on_failure, c2p_enforce_causal_atm, c2p_enforce_atm,
+                 av_drag, problem, freeze_vars,
+                 id, bc, hrsc, fv_numerical_flux)
 
   # construct Project
   eos = EquationOfState.make_EquationOfState(prms["EquationOfState"])