GRHD: fix atmosphere freezing and evolution logic...
GRHD: fix atmosphere freezing and evolution logic (!199) Fixes the following issues with the current implementation: - `update_atm_domain_of_dependence!` did not distinguish between points 1. whose neighbors are also in the bulk, 2. where one neighbor is on an interface, 3. where the point itself is on an interface. These cases are already properly handled in 2d. - `stop_atmosphere_evolution_*` methods did not account for the `c2p_freeze_atm` flag, which essentially prevented the atmosphere to ever evolve. - `update_atm_domain_of_dependence!` was activated by setting `c2p_dynamical_atm`, but it should be controlled by `c2p_enforce_causal_atm` --- Additional fixes with less impact: - remove unused parameter `id_atmosphere_density` from `GRHD` section - `c2p_set_atmosphere_on_failure` should really suppress any errors appearing in the cons2prim
Showing
- src/GRHD/GRHD.jl 10 additions, 7 deletionssrc/GRHD/GRHD.jl
- src/GRHD/callbacks.jl 56 additions, 13 deletionssrc/GRHD/callbacks.jl
- src/GRHD/cartoon.jl 2 additions, 2 deletionssrc/GRHD/cartoon.jl
- src/GRHD/cons2prim.jl 2 additions, 2 deletionssrc/GRHD/cons2prim.jl
- src/GRHD/doublecartoon.jl 2 additions, 2 deletionssrc/GRHD/doublecartoon.jl
- src/GRHD/rescaled_spherical1d.jl 2 additions, 2 deletionssrc/GRHD/rescaled_spherical1d.jl
- src/GRHD/rhs.jl 25 additions, 18 deletionssrc/GRHD/rhs.jl
- src/GRHD/setup.jl 6 additions, 3 deletionssrc/GRHD/setup.jl
- src/GRHD/spherical1d.jl 34 additions, 2 deletionssrc/GRHD/spherical1d.jl
- src/GRHD/valencia1d.jl 2 additions, 2 deletionssrc/GRHD/valencia1d.jl
Loading
Please register or sign in to comment