GRHD: fix atmosphere freezing and evolution logic
Fixes the following issues with the current implementation:
-
update_atm_domain_of_dependence!
did not distinguish between points- whose neighbors are also in the bulk,
- where one neighbor is on an interface,
- where the point itself is on an interface.
These cases are already properly handled in 2d.
-
stop_atmosphere_evolution_*
methods did not account for thec2p_freeze_atm
flag, which essentially prevented the atmosphere to ever evolve. -
update_atm_domain_of_dependence!
was activated by settingc2p_dynamical_atm
, but it should be controlled byc2p_enforce_causal_atm
Additional fixes with less impact:
- remove unused parameter
id_atmosphere_density
fromGRHD
section -
c2p_set_atmosphere_on_failure
should really suppress any errors appearing in the cons2prim
Merge request reports
Activity
Filter activity
added 1d GRHD bugfix c2p parameters labels
added 6 commits
-
f402012e - 1 commit from branch
main
- 9851e1a3 - fix atmosphere mask logic
- c353f9cc - fix logic to control when atmosphere is enforced
- 0a323a9f - c2p_set_atmosphere_on_failure should avoid errors in c2p
- b6238a9c - stop_atmosphere_evolution methods need to account for c2p_freeze_atm
- 7668a0ce - rm unused id_atmosphere_density parameter
Toggle commit list-
f402012e - 1 commit from branch
added 1 commit
- 428bfff4 - c2p_set_atmosphere_on_failure should avoid errors in c2p
added 1 commit
- 1710fb42 - always invoke the freezing version of c2p when enforcing atm
added breaking change label
mentioned in commit e2b1a670
Please register or sign in to reply