GRHD: fix atmosphere freezing and evolution logic
Fixes the following issues with the current implementation:
-
update_atm_domain_of_dependence!
did not distinguish between points- whose neighbors are also in the bulk,
- where one neighbor is on an interface,
- where the point itself is on an interface.
These cases are already properly handled in 2d.
-
stop_atmosphere_evolution_*
methods did not account for thec2p_freeze_atm
flag, which essentially prevented the atmosphere to ever evolve. -
update_atm_domain_of_dependence!
was activated by settingc2p_dynamical_atm
, but it should be controlled byc2p_enforce_causal_atm
Additional fixes with less impact:
- remove unused parameter
id_atmosphere_density
fromGRHD
section -
c2p_set_atmosphere_on_failure
should really suppress any errors appearing in the cons2prim