Skip to content
Snippets Groups Projects

GRHD: fix atmosphere freezing and evolution logic

Merged Florian Atteneder requested to merge fa/fix-atm-evolve into main

Fixes the following issues with the current implementation:

  • update_atm_domain_of_dependence! did not distinguish between points

    1. whose neighbors are also in the bulk,
    2. where one neighbor is on an interface,
    3. where the point itself is on an interface.

    These cases are already properly handled in 2d.

  • stop_atmosphere_evolution_* methods did not account for the c2p_freeze_atm flag, which essentially prevented the atmosphere to ever evolve.

  • update_atm_domain_of_dependence! was activated by setting c2p_dynamical_atm, but it should be controlled by c2p_enforce_causal_atm


Additional fixes with less impact:

  • remove unused parameter id_atmosphere_density from GRHD section
  • c2p_set_atmosphere_on_failure should really suppress any errors appearing in the cons2prim

Merge request reports

Merge request pipeline #7142 passed

Merge request pipeline passed for a4f5ea40

Test coverage 64.88% (0.00%) from 1 job
Approval is optional

Merged by Florian AttenederFlorian Atteneder 7 months ago (Aug 12, 2024 4:32pm UTC)

Merge details

  • Changes merged into main with e2b1a670 (commits were squashed).
  • Deleted the source branch.

Pipeline #7147 passed

Pipeline passed for e2b1a670 on main

Test coverage 64.89% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading