Skip to content
Snippets Groups Projects
  1. Aug 12, 2024
  2. Aug 09, 2024
  3. Aug 08, 2024
  4. Aug 07, 2024
    • Florian Atteneder's avatar
      dg1d: add lazy integrator (!198) · 6fe04532
      Florian Atteneder authored
      I am surprised that I did not need this before.
      
      This is intentionally a hacky implementation as I just need that for the thesis right now.
      
      ---
      
      This also implements
      - the total rest-mass computation for the GRHD project as a first application,
      - adds helper functions for the `Output` struct to read all data at once.
      6fe04532
  5. Aug 06, 2024
  6. Aug 05, 2024
  7. Jul 25, 2024
    • Florian Atteneder's avatar
      GRHD: add toggle to allow AV to sense based on the log10 of the variable... · 54071f65
      Florian Atteneder authored
      GRHD: add toggle to allow AV to sense based on the log10 of the variable (!190)
      
      Adds a new parameter to the `GRHD` section:
      - `av_sensor_logabs_D`: If `true` apply the AV sensor to `log(|D|)`, otherwise use `D`, where `D` is the state variable for the rest-mass density (including the volume factor).
      54071f65
    • Florian Atteneder's avatar
      Evolve: align stepper logic between all ERK implementations... · 22ea568b
      Florian Atteneder authored
      Evolve: align stepper logic between all ERK implementations (!189)
      
      This assumes that the first row in the `a` matrix of the Butcher tableau for ERK methods has only zeros, which seems to be the case for the all the methods have atm.
      
      ---
      
      Problem explanation:
      
      So far the LSERK4 and the remaining ERK steppers worked slightly different.
      The former used for the first substep the initial data array `u0`, and `u!`  for the remaining steps. That shortcut avoids a copy and appears natural for the LSERK4 algorithm.
      OTOH, in the ERK stepper we first copy `u0` into `u!`, then accumulate some substep `k`s into `u!`, and then call the RHS with `u!`. (the reason we always copied `u0` over was that we did not account for the above assumption on `a` before)
      
      The problem was now that in the GRHD evolutions we sometimes alter the state vector in the RHS computation.
      This influenced the results to the extent that we could not run the (newly added) reftest only with the LSERK4 method.
      What was happening was that when using the ERK method we never altered `u0` directly, only `u!`, whereas `u0` was altered in case the GRHD RHS decided to do so on the first step.
      Subsequent substeps of the ERK method depend upon `u0`, and so this broke things.
      22ea568b
  8. Jul 22, 2024
  9. Jul 19, 2024
    • Florian Atteneder's avatar
      ScalarEq: adds the av_recompute_substeps option... · ec189556
      Florian Atteneder authored
      ScalarEq: adds the av_recompute_substeps option (!186)
      
      In analogy to how its done for SRHD.
      
      Adds the following parameter to the `ScalarEq` section:
      - `av_recompute_substeps`: If `true` then all callbacks related to `HRSC` are ran in substeps of the time stepper.
      ec189556
  10. Jul 18, 2024
  11. Jul 17, 2024
  12. Jul 16, 2024
  13. Jun 26, 2024
  14. Jun 21, 2024
    • Florian Atteneder's avatar
      GRHD: Add option to disable the cartoon derivatives when running with the... · ff4687eb
      Florian Atteneder authored
      GRHD: Add option to disable the cartoon derivatives when running with the cartoon formulation (!180)
      
      Adds the following option to the `GRHD` section:
      - `doublecartoon_disable_derivatives`: If `true`, then the doublecartoon derivative terms are not added to the source terms.
      
      It appears that this option is senseless, because why even use the doublecartoon formulation in the first place.
      However, it turns out that these derivative terms severely degrade the quality of any TOV star tests I tried so far,
      and removing those terms from the equation helps a ton. The reason is likely that these terms contain 1/r (or 1/x) factors
      which will amplify any noise coming from the TOV star's surface and propagating inwards.
      
      Note that removing those terms changes the PDEs we solve.
      In fact, removing these terms was already considered in Bugner's paper Physical Review D, 2016.
      ff4687eb
Loading