* add more colors to highlight in which files comparisons failed

* IntegrationTests: always use terminal coloring to highlight results

* update update_test script

* include substep outputting in some reftests

* teach IntegrationTests about substep_output.h5

* add unit test

* move substep savecallback logic into convert_to_remote_savecallback!

only add remote savecallback when requested

* enable substep output

* introduce AbstractCallbackTrigger and CallbackTrigger

* add parameters

* remove experiments folder

* grhd_tov: add more slope limiter examples

* add fv_tvb_mirrored.toml TOV example

* add reftest fv_superbee_grhd_bondi_accretion

* implement rhs_slope_limiter!

* need init_ variables also for FV because of bdry conditions

* no need to compute fluxes when setting up initial data

* fixup callbacks

* add fv_grhd_bondi_accretion reftest

* a separate register! for FV

* disambiguate rhs! dispatch

* SRHD: remove unused variables from fv method

* dispatch on mesh for register!

* splice in fv method dispatch

* add new parameters

* SRHD: add reftest srhd_simple_wave_fv_tvb

* SRHD: Implement slope limiter methods

* SRHD: clean up c2p

* SRHD: use Brent's method in c2p because A42 is currently bugged

* only init relevant bdry variables

* register more vars

* wrap existing FV method as rhs_fv_central

* thin out internal rhs! usage

* organize rhs.jl

* a registration for new hrsc method

* rename _register_variables! to register!

* add new parameters

* EulerEq: add more ref tests for FV slope limiters

* EulerEq: rename hrsc option 'muscl' to 'slope_limiter' and implement
more limiters

* TCI: implement maxmod

* EulerEq: compute max speed for each substep

* add ref test fv_muscl_euler_isentropic_flow

* fix doc string of LLF

* TCI: make minmod non-allocating

* log invalid dt

* EulerEq: make muscl scheme run

* EulerEq: PoC muscl scheme

* EulerEq: run callbacks, initialdata only when certain variables are registered

* EulerEq: Add LV dependency

* evolve: init stages before capturing them

* EulerEq: strip down rhs! args

* rename _register_variables! to register! in EulerEq

* add new parameters to EulerEq project

* fix fn name

* remove unused file

* add reftest fv_muscl_burgers_sine

* fixup muscl implementation; also make it work with arbitrary fluxes

* fix parameter check

* rename prm hrsc_omega to muscl_omega

* add ref test for muscl scheme

* implement muscl scheme

* implement new parameters

* fix reftest output coloring when non interactive

* add TODO branches for bdry conds

* fixup check for coordinate signularity on grid

* implement different bdry conditions for bondi and tov problem

also update bondi reftest

* more example parfiles

* c2p: fix computation of W

* make training wheel ID work independent of method

* fix ID interpolation for FV method

* cleanup fv_rhs.jl

* skip symmetry imposition if signularity is not on grid

* mirror TOV initial data for mirrored domains

* add bernstein tov example

* implement bernsteining

* add missing cache wrapper for bdry variables

* reconstruct dynamic variables after viscosity computation

* add perturbation_rho parameter

* add a D dependency to viscosity

* allow to only evolve initial data in star's interior

* add rho h W^2 variable for analysis

* make initial viscosity work

* allow slightly negative energies

* pull out y0 from vr limiter in cons2prim

* add training_wheels options which smooths initial dynamical variables

* update example parfiles

* update tov examples

* wip: tinker with c2p and viscosity computation in atmospheric regions

* filter AV from atmosphere cells

* enable inflow condition on inner boundary

* fix imposition of EoS bounds in cons2prim

also disabling lower bracket adjustment, because it seems to be wrong
with this the FV method can now run

* cleanup cons2prim

* wip: tinkering with cons2prim

* compute AV for initial data

* implement av_drag option

* wip: tinker with c2p routine

* add c2p analysis vars

* stabilize origin of TOV with Neumann bdry conditions

* implement entropy_variables_rescaled_spherical1d

* use log(D) for MDA viscosity because it is more sensitive

* fix maxspeed_rescaled_spherical1d

* example parfile that allows to evolve the tov for quite a while

* apply velocity limiter from dumbser at the end of cons2prim

* fix maxspeed

* add update_test helper script

* add ref test balancedburgers_kink_avmda

* fix time step computation for AV method

* simplify inf clipping

* mda: use local instead of global speed to compute baseline av

* favor likely case in if in mda computation

* implement av dragging

* add av_drag parameter

* spice up IntergrationTests logging with colors

* fix 0th order AV smoother

* implement BalancedBurgers equation

* fix fv stepping to also add dt to source term

* cleanup

* rm old ERK evolutions

* fixup fv ref tests

* rename rk steppers to ode_step!

* for FV methods forward dt from evolution via cache

fixes mismatch in dt values that were used in the time stepper and the
rhs functions
the mismatch was caused by the time stepper always applying the CFL
(and output callbacks could further shorten the proposed time step)
eventually, this lead to wrong propagation speeds, which can be seen
by the test results of fv_advection_sine (we expect same profile as
initial data after two revolutions, but we actually saw 2.5)

only add dt for FV evolutions

* fixup kwarg forwarding in register_variables

* implement a minimal git dirty logging

* restructure variable registration

* implement rhs for av regularization

* update callbacks

* implement ldg and av regularization

* mesh: forward more methods to cache

* dispatch TODO error

* forward Cache methods to Mesh

* nospecialize setup and initialdata

* update examples once more

* remove comments

* cleanup: remove codegen for now

* IntegartionTests: add grhd_tov_spherical1d ref test

* IntegrationTests: remove reltol from grhd_bondi_accretion test

* spherical1d: fix missing shift from maxspeed computation

* cleanup

* make spherical1d formulation work when r=0 is included by removing potential nans in source terms by enforcing symmetry

* make impose_symmetry! dispatch on project

* add tov example that runs with spherical1d formulation

* wip: change maxspeed implementation for tov star initial data

* cons2prim: use non-zero values for rho, eps thresholds

* fix: set atm density in bondi_accretion initial data

* implement tov initial data for spherical1d formulation

* add formulation parameter

* implement rhs for FVElement and rescaled_spherical1d

* implement equations for FVElement and rescaled_spherical1d

* mesh: implement differentiate for FVElement

* add grhd example par files

* update notebooks

* fix missing lapse factor in source terms

* fix typos

* fixup initialdata setup

* derivative computation needs jacobi

* rename cons2prim routines

* add atmosphering to cons2prim

* implement rhs! for rescaled_spherical1d formulation

* specialize timespeed computation based on equations

* add specialized equations for the rescaled GRHD version

* implement initialdata setup for tov case

* spherical accretion:make sure K, Gamma agree with loaded data

* expose spectral differentiation

* wrap SphericalAccretion solver into module; recompute bondi_accretion.h5 with less radial points

* refactor TOV solver to use OrdinaryDiffEq

* initialdata: cleanup dir

* add bondi accretion as ref test

* fix up loading of id file

* fv_rhs: implement fv_update_step! with source term

* add ROOTDIR const global so that parfiles can specify paths relative to project root

* update SphericalAccretion.jl

* update sympy nb

* cleanup initialdata setup

* equations: fix up Tmunu computation

* Revert "fix source term in dg and fv rhs computation"

This reverts commit 161cc034.

* Replace Interpolations.jl with BasicInterpolators.jl

* equation: add missing flux terms to sources; use outflow bdry condition on inner radius

* comments in cons2prim

* implement momentum constraint for debugging

* test SphericalAccretion

- copy Bugner's C version of the solver
- compare my results with Bugner's -- good agreement
- compare against literature results (Papadopoulos 1998,1999) --
  discrepancy in sign of vr, ur, otherwise good agreement

* SphericalAccretion: fix wrong definition of uc^r and Vc

* tweak impl more

* fix source term in dg and fv rhs computation

* fix equations and implement fv method

* equations: combine flux and source computation

* math: update spherical_accretion notebook

* SRHD: export module

* re-implemented GRHD eqs with a non-zero shift

* initialdata: add grhd_source.codegen.jl that was generated with TensorComponents.jl

* deps: need Interpolations.jl for initial data setup

* update math/spherical_accretion.py

* update setup

* start initialdata setup for bondi problem

* rework rhs.jl

* update deps and parameters

* update type defs

* initialdata: add HDF5 dep; write h5 output for SphericalAccretion.jl

* rename cons2prim.jl

* remove unused files

@with_signature: only need one LineNumberNode per @accepts, @returns unpacking block (!100)

* @with_signature: only need one LineNumberNode per @accepts, @returns unpacking block

* @with_signature: Insert 'LineNumberNodes' when unpacking vectors

* remove Base.getproperty overloads for meshes

* fixup Base.length definition for Mesh

* fix unit tests

* add the mesh arg (second_arg) as an ordinary argument into with_signature fn signature; also remove unused state_indices interface method

* remove mesh kw from with_signature function signature

* temporarily disable @timeit around broadcast_computation, because it introduces allocs

* inline fn call in broadcast_computation to avoid allocs

* use views and maximum(abs, ...) to avoid allocs

* make min_grid_spacing dimension agnostic for FVElement

* inline mesh helpers

* more let arguments, just in case closure bug hits again ...

* stop using properties of mesh

* don't use absolute_maximum

* parameterize Project on equation

* remove rootfinders.jl and update unit tests

* remove my rootfinder types

* rework SphericalAccretion to use CairoMakie.jl and Roots.jl

* remove variablesarray.jl; rename _VariablesDict to Variables

* fix up readme badges

* update line coverage computation

* remove unused tests: test_variables.jl

* update coverage exclude patterns

* rename project dg1dTests to UnitTests

* remove BenchmarkTools from dg1dTests deps

remove BenchmarkTools

* rename new_broadcast_... to broadcast_...; also export broadcast_... methods

* eliminate legac=false option

* remove legacy option form @with_signature

fixup default options

* disable with_signature functions that used legacy version

* evict all occurences of broadcast_(volume|faces|bdry)_2!